wifi: ath12k: Avoid memory leak while enabling statistics

Driver uses monitor destination rings for extended statistics mode and
standalone monitor mode. In extended statistics mode, TLVs are parsed from
the buffer received from the monitor destination ring and assigned to the
ppdu_info structure to update per-packet statistics. In standalone monitor
mode, along with per-packet statistics, the packet data (payload) is
captured, and the driver updates per MSDU to mac80211.

When the AP interface is enabled, only extended statistics mode is
activated. As part of enabling monitor rings for collecting statistics,
the driver subscribes to HAL_RX_MPDU_START TLV in the filter
configuration. This TLV is received from the monitor destination ring, and
kzalloc for the mon_mpdu object occurs, which is not freed, leading to a
memory leak. The kzalloc for the mon_mpdu object is only required while
enabling the standalone monitor interface. This causes a memory leak while
enabling extended statistics mode in the driver.

Fix this memory leak by removing the kzalloc for the mon_mpdu object in
the HAL_RX_MPDU_START TLV handling. Additionally, remove the standalone
monitor mode handlings in the HAL_MON_BUF_ADDR and HAL_RX_MSDU_END TLVs.
These TLV tags will be handled properly when enabling standalone monitor
mode in the future.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
Link: https://patch.msgid.link/20241223060132.3506372-13-quic_ppranees@quicinc.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>

diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c
index 4b35dfcbdfe1888751df8fae2844f20cb4ddd8f8..23b1a41c6fd2b5446285fbf19f773f9115c2ba7f 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/dp_mon.c
+++ b/drivers/net/wireless/ath/ath12k/dp_mon.c
@@ -567,7 +567,6 @@ ath12k_dp_mon_rx_parse_status_tlv(struct ath12k *ar,
                                  struct ath12k_mon_data *pmon,
                                  const struct hal_tlv_64_hdr *tlv)
 {
-       struct ath12k_base *ab = ar->ab;
        struct hal_rx_mon_ppdu_info *ppdu_info = &pmon->mon_ppdu_info;
        const void *tlv_data = tlv->value;
        u32 info[7], userid;
@@ -748,7 +747,6 @@ ath12k_dp_mon_rx_parse_status_tlv(struct ath12k *ar,
        }
        case HAL_RX_MPDU_START: {
                const struct hal_rx_mpdu_start *mpdu_start = tlv_data;
-               struct dp_mon_mpdu *mon_mpdu = pmon->mon_mpdu;
                u16 peer_id;
 
                info[1] = __le32_to_cpu(mpdu_start->info1);
@@ -765,65 +763,17 @@ ath12k_dp_mon_rx_parse_status_tlv(struct ath12k *ar,
                                u32_get_bits(info[0], HAL_RX_MPDU_START_INFO1_PEERID);
                }
 
-               mon_mpdu = kzalloc(sizeof(*mon_mpdu), GFP_ATOMIC);
-               if (!mon_mpdu)
-                       return HAL_RX_MON_STATUS_PPDU_NOT_DONE;
-
                break;
        }
        case HAL_RX_MSDU_START:
                /* TODO: add msdu start parsing logic */
                break;
-       case HAL_MON_BUF_ADDR: {
-               struct dp_rxdma_mon_ring *buf_ring = &ab->dp.rxdma_mon_buf_ring;
-               const struct dp_mon_packet_info *packet_info = tlv_data;
-               int buf_id = u32_get_bits(packet_info->cookie,
-                                         DP_RXDMA_BUF_COOKIE_BUF_ID);
-               struct sk_buff *msdu;
-               struct dp_mon_mpdu *mon_mpdu = pmon->mon_mpdu;
-               struct ath12k_skb_rxcb *rxcb;
-
-               spin_lock_bh(&buf_ring->idr_lock);
-               msdu = idr_remove(&buf_ring->bufs_idr, buf_id);
-               spin_unlock_bh(&buf_ring->idr_lock);
-
-               if (unlikely(!msdu)) {
-                       ath12k_warn(ab, "monitor destination with invalid buf_id %d\n",
-                                   buf_id);
-                       return HAL_RX_MON_STATUS_PPDU_NOT_DONE;
-               }
-
-               rxcb = ATH12K_SKB_RXCB(msdu);
-               dma_unmap_single(ab->dev, rxcb->paddr,
-                                msdu->len + skb_tailroom(msdu),
-                                DMA_FROM_DEVICE);
-
-               if (mon_mpdu->tail)
-                       mon_mpdu->tail->next = msdu;
-               else
-                       mon_mpdu->tail = msdu;
-
-               ath12k_dp_mon_buf_replenish(ab, buf_ring, 1);
-
-               break;
-       }
-       case HAL_RX_MSDU_END: {
-               const struct rx_msdu_end_qcn9274 *msdu_end = tlv_data;
-               bool is_first_msdu_in_mpdu;
-               u16 msdu_end_info;
-
-               msdu_end_info = __le16_to_cpu(msdu_end->info5);
-               is_first_msdu_in_mpdu = u32_get_bits(msdu_end_info,
-                                                    RX_MSDU_END_INFO5_FIRST_MSDU);
-               if (is_first_msdu_in_mpdu) {
-                       pmon->mon_mpdu->head = pmon->mon_mpdu->tail;
-                       pmon->mon_mpdu->tail = NULL;
-               }
-               break;
-       }
+       case HAL_MON_BUF_ADDR:
+               return HAL_RX_MON_STATUS_BUF_ADDR;
+       case HAL_RX_MSDU_END:
+               return HAL_RX_MON_STATUS_MSDU_END;
        case HAL_RX_MPDU_END:
-               list_add_tail(&pmon->mon_mpdu->list, &pmon->dp_rx_mon_mpdu_list);
-               break;
+               return HAL_RX_MON_STATUS_MPDU_END;
        case HAL_DUMMY:
                return HAL_RX_MON_STATUS_BUF_DONE;
        case HAL_RX_PPDU_END_STATUS_DONE:
@@ -1215,7 +1165,10 @@ ath12k_dp_mon_parse_rx_dest(struct ath12k *ar, struct ath12k_mon_data *pmon,
                if ((ptr - skb->data) >= DP_RX_BUFFER_SIZE)
                        break;
 
-       } while (hal_status == HAL_RX_MON_STATUS_PPDU_NOT_DONE);
+       } while ((hal_status == HAL_RX_MON_STATUS_PPDU_NOT_DONE) ||
+                (hal_status == HAL_RX_MON_STATUS_BUF_ADDR) ||
+                (hal_status == HAL_RX_MON_STATUS_MPDU_END) ||
+                (hal_status == HAL_RX_MON_STATUS_MSDU_END));
 
        return hal_status;
 }

diff --git a/drivers/net/wireless/ath/ath12k/hal_rx.h b/drivers/net/wireless/ath/ath12k/hal_rx.h
index b60c172d131b8dea3ed38767fd6dd0d81a8d265b..96954b2f7ca66567bec183732611c2c8de53e950 100644 (file)
--- a/drivers/net/wireless/ath/ath12k/hal_rx.h
+++ b/drivers/net/wireless/ath/ath12k/hal_rx.h
@@ -108,6 +108,9 @@ enum hal_rx_mon_status {
        HAL_RX_MON_STATUS_PPDU_NOT_DONE,
        HAL_RX_MON_STATUS_PPDU_DONE,
        HAL_RX_MON_STATUS_BUF_DONE,
+       HAL_RX_MON_STATUS_BUF_ADDR,
+       HAL_RX_MON_STATUS_MPDU_END,
+       HAL_RX_MON_STATUS_MSDU_END,
 };
 
 #define HAL_RX_MAX_MPDU                256