terminal: ttyname_r() returns an error number on failure

In other words, how inconsistent can an API be?

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/terminal.c b/src/lxc/terminal.c
index 2c73c8f27841aa36c7e1376da337024a07b54816..8850a968718f839ea325acb809e5620c8013bb04 100644 (file)
--- a/src/lxc/terminal.c
+++ b/src/lxc/terminal.c
@@ -950,7 +950,7 @@ static int lxc_terminal_create_native(const char *name, const char *lxcpath, str
        }
 
        ret = ttyname_r(terminal->pty, terminal->name, sizeof(terminal->name));
-       if (ret < 0) {
+       if (ret) {
                SYSWARN("Failed to retrieve name of terminal pty");
                goto err;
        }