]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
lxc: fix a memory leak
authorShi Lei <shi_lei@massclouds.com>
Wed, 16 Dec 2020 06:01:06 +0000 (14:01 +0800)
committerLaine Stump <laine@redhat.com>
Wed, 16 Dec 2020 19:43:51 +0000 (14:43 -0500)
In virLXCProcessSetupInterfaceTap, containerVeth needs to be freed on
failure.

Signed-off-by: Shi Lei <shi_lei@massclouds.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/lxc/lxc_process.c

index 85d0287a3573ff402efd613a78057efd6323b897..0f7c929535cd2f8606bec3919b79fe54ea00b01d 100644 (file)
@@ -303,7 +303,7 @@ virLXCProcessSetupInterfaceTap(virDomainDefPtr vm,
                                const char *brname)
 {
     char *parentVeth;
-    char *containerVeth = NULL;
+    g_autofree char *containerVeth = NULL;
     const virNetDevVPortProfile *vport = virDomainNetGetActualVirtPortProfile(net);
 
     VIR_DEBUG("calling vethCreate()");
@@ -357,7 +357,7 @@ virLXCProcessSetupInterfaceTap(virDomainDefPtr vm,
         virDomainConfNWFilterInstantiate(vm->name, vm->uuid, net, false) < 0)
         return NULL;
 
-    return containerVeth;
+    return g_steal_pointer(&containerVeth);
 }