]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
power: sequencing: qcom-wcn: fix error path for VDDIO handling
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Sat, 7 Feb 2026 10:28:52 +0000 (12:28 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Mon, 9 Feb 2026 09:32:27 +0000 (10:32 +0100)
In case getting VDDIO regulator returned an error, WCN power sequencing
driver passes ret to dev_err_probe() as the error code, however it is
known that ret is 0 at this point. Pass PTR_ERR(ctx->vddio) instead.

Fixes: 0eb85f468ef5 ("power: sequencing: qcom-wcn: add support for WCN39xx")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/aYXvQxKqmjP_sdCd@stanley.mountain/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260207-fix-wcn39xx-v1-1-df0606108ce2@oss.qualcomm.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/power/sequencing/pwrseq-qcom-wcn.c

index 46a484b0b5a110a34d48ffe06479ef5115c5fc8b..b55b4317e21b626e050e022648147770ca7f386e 100644 (file)
@@ -489,7 +489,7 @@ static int pwrseq_qcom_wcn_probe(struct platform_device *pdev)
        if (ctx->pdata->has_vddio) {
                ctx->vddio = devm_regulator_get(dev, "vddio");
                if (IS_ERR(ctx->vddio))
-                       return dev_err_probe(dev, ret, "Failed to get VDDIO\n");
+                       return dev_err_probe(dev, PTR_ERR(ctx->vddio), "Failed to get VDDIO\n");
        }
 
        ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);