]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: PCI: simplify code with acpi_get_local_u64_address()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 21 Jan 2026 08:50:49 +0000 (09:50 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 23 Jan 2026 19:11:21 +0000 (20:11 +0100)
Now we have a helper so there's no need to open-code.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20260121085105.2282380-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/pci_slot.c

index 741bcc9d6d6aa9f3b43e970744a86dfe6e6e283e..15234b65ea22e13b65a4b01abe7d567e6f99b4ad 100644 (file)
@@ -42,8 +42,9 @@ static int
 check_slot(acpi_handle handle, unsigned long long *sun)
 {
        int device = -1;
-       unsigned long long adr, sta;
+       unsigned long long sta;
        acpi_status status;
+       u64 adr;
        struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
 
        acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer);
@@ -56,10 +57,9 @@ check_slot(acpi_handle handle, unsigned long long *sun)
                        goto out;
        }
 
-       status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
-       if (ACPI_FAILURE(status)) {
-               pr_debug("_ADR returned %d on %s\n",
-                        status, (char *)buffer.pointer);
+       if (acpi_get_local_u64_address(handle, &adr)) {
+               pr_debug("_ADR returned with failure on %s\n",
+                        (char *)buffer.pointer);
                goto out;
        }