]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
build: always include libvirt_lxc.syms in tarball
authorEric Blake <eblake@redhat.com>
Thu, 2 May 2013 23:35:50 +0000 (17:35 -0600)
committerEric Blake <eblake@redhat.com>
Mon, 6 May 2013 19:59:48 +0000 (13:59 -0600)
On a mingw build, 'make distcheck' fails with:

  GEN      libvirt_qemu.def
make[3]: *** No rule to make target `../../src/libvirt_lxc.syms', needed by `libvirt_lxc.def'.  Stop.

I traced it to a missing entry in EXTRA_DIST.  But rather than keep
the entire list in sync, it is easier to list the three syms files
that drive .so files directly, and then reuse existing makefile
variables for the remaining files (that is, I validated that all
remaining files are added to SYM_FILES, possibly via USED_SYM_FILES,
according to makefile conditionals).

Problem introduced in commit 3d1596b (v1.0.2).

* src/Makefile.am (EXTRA_DIST): Ensure all syms files are shipped.

Signed-off-by: Eric Blake <eblake@redhat.com>
src/Makefile.am

index 299b8fd0dc59fce0bf46ab73da384fef83d0ab6d..6c2788c59bf7f8df2e33569b3ad2a98c2158a69f 100644 (file)
@@ -1548,20 +1548,11 @@ SYM_FILES += $(srcdir)/libvirt_atomic.syms
 endif
 
 EXTRA_DIST += \
-  libvirt_public.syms          \
-  libvirt_private.syms         \
-  libvirt_atomic.syms          \
-  libvirt_driver_modules.syms  \
-  libvirt_daemon.syms          \
-  libvirt_linux.syms           \
-  libvirt_esx.syms             \
-  libvirt_openvz.syms          \
-  libvirt_qemu.syms            \
-  libvirt_sasl.syms            \
-  libvirt_gnutls.syms          \
-  libvirt_vmx.syms             \
-  libvirt_xenxs.syms   \
-  libvirt_libssh2.syms
+       libvirt_public.syms             \
+       libvirt_lxc.syms                \
+       libvirt_qemu.syms               \
+       $(SYM_FILES)                    \
+       $(NULL)
 
 GENERATED_SYM_FILES = \
        libvirt.syms libvirt.def libvirt_qemu.def libvirt_lxc.def