s3/libsmb: cleanup discover_dc_dns, only set out params on success

Signed-off-by: Noel Power <npower@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
index a8d3c665bba9ccec8a6d3317b1564adc1618caaa..42db03ac52c5ecced7d6f06ea9f4cc68a7000465 100644 (file)
--- a/source3/libsmb/dsgetdcname.c
+++ b/source3/libsmb/dsgetdcname.c
@@ -769,17 +769,20 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx,
                }
        }
 
-       *returned_dclist = dclist;
-       *return_count = (int)ret_count;
 
-       if (*return_count < 0) {
+       if ((int)ret_count < 0) {
                TALLOC_FREE(dcs);
                TALLOC_FREE(dclist);
                TALLOC_FREE(dns_lookups);
                return NT_STATUS_INTERNAL_ERROR;
        }
 
+
        if (ret_count > 0) {
+               TALLOC_FREE(dcs);
+               TALLOC_FREE(dns_lookups);
+               *returned_dclist = dclist;
+               *return_count = (int)ret_count;
                return NT_STATUS_OK;
        }