PM / devfreq: event: Call of_node_put() only once in devfreq_event_get_edev_by_phandle()

An of_node_put(node) call was immediately used after a null pointer check
for the local variable “edev” at the end of this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Link: https://lore.kernel.org/lkml/0f103384-376c-41f0-a35c-8ad98327d6cb@web.de/
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 3ebac2496679b5e2d7d6096bf62294ebadae1611..70219099c60400cd2d4ac66da2e333c7d33decd7 100644 (file)
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -244,13 +244,9 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev,
        edev = NULL;
 out:
        mutex_unlock(&devfreq_event_list_lock);
-
-       if (!edev) {
-               of_node_put(node);
-               return ERR_PTR(-ENODEV);
-       }
-
        of_node_put(node);
+       if (!edev)
+               return ERR_PTR(-ENODEV);
 
        return edev;
 }