BUG/MEDIUM: pools/memprofile: always clean stale pool info on pool_destroy()

There's actually a problem with memprofiles: the pool pointer is stored
in ->info but some pools are replaced during startup, such as the trash
pool, leaving a dangling pointer there, that may randomly report crap or
even crash during "show profile memory".

Let's make pool_destroy() call memprof_remove_stale_info() added
by previous patch so that these entries are properly unregistered.

This must be backported along with the previous patch (MINOR:
activity/memprofile: offer a function to unregister stale info) as
far as 2.8.

diff --git a/src/pool.c b/src/pool.c
index 31c5c225105031fb11f6c8936c840b6b50755158..f4a4af10056ce682b26b0ce489096c88b1af0aa6 100644 (file)
--- a/src/pool.c
+++ b/src/pool.c
@@ -946,6 +946,9 @@ void *pool_destroy(struct pool_head *pool)
                        /* note that if used == 0, the cache is empty */
                        free(pool->base_addr);
                }
+
+               /* make sure this pool is no longer referenced in memory profiling */
+               memprof_remove_stale_info(pool);
        }
        return NULL;
 }