]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: fbtft: Remove ftrace-like logging
authorRiyan Dhiman <riyandhiman14@gmail.com>
Thu, 25 Jul 2024 13:03:51 +0000 (18:33 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Jul 2024 07:20:44 +0000 (09:20 +0200)
Adhere to Linux kernel coding style

Reported by checkpatch:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
Link: https://lore.kernel.org/r/20240725130351.14877-1-riyandhiman14@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 files changed:
drivers/staging/fbtft/fb_ili9320.c
drivers/staging/fbtft/fb_ra8875.c
drivers/staging/fbtft/fb_sh1106.c
drivers/staging/fbtft/fb_ssd1289.c
drivers/staging/fbtft/fb_ssd1306.c
drivers/staging/fbtft/fb_ssd1325.c
drivers/staging/fbtft/fb_ssd1331.c
drivers/staging/fbtft/fb_ssd1351.c
drivers/staging/fbtft/fb_uc1611.c
drivers/staging/fbtft/fbtft-bus.c
drivers/staging/fbtft/fbtft-core.c
drivers/staging/fbtft/fbtft-sysfs.c

index 0be7c2d51548ad85a03c75009412c9443b4fa6de..050fc2367c122fd1c0488dfcb803c0234705fb14 100644 (file)
@@ -35,8 +35,6 @@ static int init_display(struct fbtft_par *par)
        par->fbtftops.reset(par);
 
        devcode = read_devicecode(par);
-       fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "Device code: 0x%04X\n",
-                     devcode);
        if ((devcode != 0x0000) && (devcode != 0x9320))
                dev_warn(par->info->device,
                         "Unrecognized Device code: 0x%04X (expected 0x9320)\n",
index 398bdbf53c9a597098f0f05c48904332b6afcb59..0ab1de6647d07488b4ab842132dabcb6c6628fce 100644 (file)
@@ -41,13 +41,6 @@ static int init_display(struct fbtft_par *par)
 {
        gpiod_set_value(par->gpio.dc, 1);
 
-       fbtft_par_dbg(DEBUG_INIT_DISPLAY, par,
-                     "%s()\n", __func__);
-       fbtft_par_dbg(DEBUG_INIT_DISPLAY, par,
-                     "display size %dx%d\n",
-               par->info->var.xres,
-               par->info->var.yres);
-
        par->fbtftops.reset(par);
 
        if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) {
index 9685ca516a0e3c234c8be5f4f960746877b770ff..e4c50c1ffed0590dd7adbf929798bcb579b13703 100644 (file)
@@ -88,9 +88,6 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 
 static int blank(struct fbtft_par *par, bool on)
 {
-       fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
-                     __func__, on ? "true" : "false");
-
        write_reg(par, on ? 0xAE : 0xAF);
 
        return 0;
index f27bab38b3ec4cce6a1ebf322115aece4d1606b9..255a6d21ca8e5de87e4be1a957f3220745c914a1 100644 (file)
@@ -93,9 +93,6 @@ static int set_var(struct fbtft_par *par)
 {
        if (par->fbtftops.init_display != init_display) {
                /* don't risk messing up register 11h */
-               fbtft_par_dbg(DEBUG_INIT_DISPLAY, par,
-                             "%s: skipping since custom init_display() is used\n",
-                             __func__);
                return 0;
        }
 
index 6cf9df579e88b69470422d2d1cdbc852e6c4bd9d..478d710469b91e3838e23185bcaf5591f14b3dd4 100644 (file)
@@ -148,9 +148,6 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 
 static int blank(struct fbtft_par *par, bool on)
 {
-       fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
-                     __func__, on ? "true" : "false");
-
        if (on)
                write_reg(par, 0xAE);
        else
index 796a2ac3e19486c9d64296781bc950dfd25702e9..256b0b87a9305eba7df16e52ed61a544d9e31c8b 100644 (file)
@@ -72,10 +72,6 @@ static uint8_t rgb565_to_g16(u16 pixel)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-       fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-                     "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe,
-                     ye);
-
        write_reg(par, 0x75);
        write_reg(par, 0x00);
        write_reg(par, 0x3f);
@@ -86,9 +82,6 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 
 static int blank(struct fbtft_par *par, bool on)
 {
-       fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
-                     __func__, on ? "true" : "false");
-
        if (on)
                write_reg(par, 0xAE);
        else
@@ -109,8 +102,6 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
 {
        int i;
 
-       fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
-
        for (i = 0; i < GAMMA_LEN; i++) {
                if (i > 0 && curves[i] < 1) {
                        dev_err(par->info->device,
index ec5eced7f8cbd6746b869a7e012fba59abbed0d8..06b7056d6c71c011d92a61692ca4cafb481d7df4 100644 (file)
@@ -167,8 +167,6 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
 
 static int blank(struct fbtft_par *par, bool on)
 {
-       fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
-                     __func__, on ? "true" : "false");
        if (on)
                write_reg(par, 0xAE);
        else
index ca2cba2185ae3e684c0dbc329043194bee1a537c..aa8c1ff2a13cee934f354b418c8815ce4044bcf6 100644 (file)
@@ -72,9 +72,6 @@ static int set_var(struct fbtft_par *par)
 
        if (par->fbtftops.init_display != init_display) {
                /* don't risk messing up register A0h */
-               fbtft_par_dbg(DEBUG_INIT_DISPLAY, par,
-                             "%s: skipping since custom init_display() is used\n",
-                              __func__);
                return 0;
        }
 
index f61e373c75e9660897e7f1557bd1ed46353f6655..ca35b386a12d533f622a218b96770eb1e26d1eb5 100644 (file)
@@ -135,9 +135,6 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 
 static int blank(struct fbtft_par *par, bool on)
 {
-       fbtft_par_dbg(DEBUG_BLANK, par, "(%s=%s)\n",
-                     __func__, on ? "true" : "false");
-
        if (on)
                write_reg(par, 0xA8 | 0x00);
        else
index 3d422bc1164116bebf81ad8f7e5050310c72ee44..30e436ff19e4c46e25991dacf4ee7c18772a523f 100644 (file)
@@ -129,9 +129,6 @@ int fbtft_write_vmem16_bus8(struct fbtft_par *par, size_t offset, size_t len)
        int ret = 0;
        size_t startbyte_size = 0;
 
-       fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s(offset=%zu, len=%zu)\n",
-                     __func__, offset, len);
-
        remain = len / 2;
        vmem16 = (u16 *)(par->info->screen_buffer + offset);
 
@@ -182,9 +179,6 @@ int fbtft_write_vmem16_bus9(struct fbtft_par *par, size_t offset, size_t len)
        int i;
        int ret = 0;
 
-       fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s(offset=%zu, len=%zu)\n",
-                     __func__, offset, len);
-
        if (!par->txbuf.buf) {
                dev_err(par->info->device, "%s: txbuf.buf is NULL\n", __func__);
                return -1;
@@ -232,9 +226,6 @@ int fbtft_write_vmem16_bus16(struct fbtft_par *par, size_t offset, size_t len)
 {
        u16 *vmem16;
 
-       fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s(offset=%zu, len=%zu)\n",
-                     __func__, offset, len);
-
        vmem16 = (u16 *)(par->info->screen_buffer + offset);
 
        /* no need for buffered write with 16-bit bus */
index 8e2fd0c0fee21be2013e5fe5ccec0d50fdb8c026..ffa524dc945e8f241a58bbb393f0d6996045443c 100644 (file)
@@ -215,8 +215,6 @@ static void fbtft_reset(struct fbtft_par *par)
        if (!par->gpio.reset)
                return;
 
-       fbtft_par_dbg(DEBUG_RESET, par, "%s()\n", __func__);
-
        gpiod_set_value_cansleep(par->gpio.reset, 1);
        usleep_range(20, 40);
        gpiod_set_value_cansleep(par->gpio.reset, 0);
@@ -1052,8 +1050,6 @@ static int fbtft_verify_gpios(struct fbtft_par *par)
        struct fbtft_platform_data *pdata = par->pdata;
        int i;
 
-       fbtft_par_dbg(DEBUG_VERIFY_GPIOS, par, "%s()\n", __func__);
-
        if (pdata->display.buswidth != 9 &&  par->startbyte == 0 &&
            !par->gpio.dc) {
                dev_err(par->info->device,
@@ -1157,9 +1153,6 @@ int fbtft_probe_common(struct fbtft_display *display,
        else
                dev = &pdev->dev;
 
-       if (unlikely(display->debug & DEBUG_DRIVER_INIT_FUNCTIONS))
-               dev_info(dev, "%s()\n", __func__);
-
        pdata = dev->platform_data;
        if (!pdata) {
                pdata = fbtft_properties_read(dev);
index 39e8d28066cbe1b06ea94681b99c2cbf244a872e..e45c90a03a903ea3433ca7cde32bd52479142ea6 100644 (file)
@@ -27,13 +27,9 @@ int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *curves,
        int curve_counter, value_counter;
        int _count;
 
-       fbtft_par_dbg(DEBUG_SYSFS, par, "%s() str=\n", __func__);
-
        if (!str || !curves)
                return -EINVAL;
 
-       fbtft_par_dbg(DEBUG_SYSFS, par, "%s\n", str);
-
        tmp = kmemdup(str, size + 1, GFP_KERNEL);
        if (!tmp)
                return -ENOMEM;