]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#1188] fixed unittests
authorRazvan Becheriu <razvan@isc.org>
Mon, 27 Apr 2020 19:06:12 +0000 (22:06 +0300)
committerRazvan Becheriu <razvan@isc.org>
Thu, 30 Apr 2020 10:53:48 +0000 (13:53 +0300)
src/bin/dhcp4/tests/ctrl_dhcp4_srv_unittest.cc
src/bin/dhcp4/tests/hooks_unittest.cc
src/bin/dhcp6/tests/ctrl_dhcp6_srv_unittest.cc
src/bin/dhcp6/tests/hooks_unittest.cc
src/lib/dhcpsrv/tests/multi_threading_config_parser_unittest.cc

index 753df545ef340bfc2d3f40a9667e3edbc17ad998..9c403d382ff42244d4997dc36716380ccf7a1b6e 100644 (file)
@@ -461,7 +461,8 @@ TEST_F(CtrlChannelDhcpv4SrvTest, libreload) {
     EXPECT_TRUE(checkMarkerFile(LOAD_MARKER_FILE, "1212"));
 }
 
-// Check that the "libreload" command will reload libraries when MT is enabled
+// Check that the "libreload" command will fail to reload libraries which are
+// not compatible when multi-threading is enabled
 TEST_F(CtrlChannelDhcpv4SrvTest, libreloadFailMultiThreading) {
     createUnixChannelServer();
 
index 8f83e824ab5754c4b253eb88f39c5e35958c1781..4e3d0ae858e6477665f4cdacaab58f6f34a9a10e 100644 (file)
@@ -2756,7 +2756,7 @@ TEST_F(LoadUnloadDhcpv4SrvTest, unloadLibraries) {
 }
 
 // Verifies that libraries incompatible with multi threading are not loaded by
-// the server
+// the server.
 // The callout libraries write their library index number to a marker
 // file upon load and unload, making it simple to test whether or not
 // the load and unload callouts have been invoked.
index 9cec48651c067f45d1eef47c2fa689b3316aff4f..a90978dff23113a334b83c313b90596ae87f7e5e 100644 (file)
@@ -475,7 +475,8 @@ TEST_F(CtrlChannelDhcpv6SrvTest, libreload) {
     EXPECT_TRUE(checkMarkerFile(LOAD_MARKER_FILE, "1212"));
 }
 
-// Check that the "libreload" command will reload libraries when MT is enabled
+// Check that the "libreload" command will fail to reload libraries which are
+// not compatible when multi-threading is enabled
 TEST_F(CtrlChannelDhcpv6SrvTest, libreloadFailMultiThreading) {
     createUnixChannelServer();
 
index 985007734ae23d221de10e4b3f01a089b99f34f1..e6ff78b28ae29dd554068c85b8ea085328b37502 100644 (file)
@@ -4899,7 +4899,7 @@ TEST_F(LoadUnloadDhcpv6SrvTest, unloadLibraries) {
 }
 
 // Verifies that libraries incompatible with multi threading are not loaded by
-// the server
+// the server.
 // The callout libraries write their library index number to a marker
 // file upon load and unload, making it simple to test whether or not
 // the load and unload callouts have been invoked.
index c5d938ffe6057837f7824381763f98f218f7e6a9..1f3b994bbd59056a42cb2dca56668ef3811f5172 100644 (file)
@@ -54,7 +54,7 @@ TEST_F(MultiThreadingConfigParserTest, validContent) {
         {
         "enable-multi-threading, without thread-pool-size or packet-queue-size",
         "{ \n"
-        "   \"enable-multi-threading\": true, \n"
+        "   \"enable-multi-threading\": true \n"
         "} \n"
         },
         {