Fix buffer overflow when adding an user to a group. Thanks to Peter Vrabec.

diff --git a/ChangeLog b/ChangeLog
index 9424dc8039821326420ae25956e0418e71f33487..26b8a465e09fe1f2d450bf58cceeed64b5edc075 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2008-02-18  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * NEWS, src/groupmems.c: Fix buffer overflow when adding an user
+       to a group. Thanks to Peter Vrabec.
+
 2008-02-14  Nicolas François  <nicolas.francois@centraliens.net>
 
        * NEWS, etc/useradd: Change the default HOME directory in

diff --git a/NEWS b/NEWS
index ff3056aa7fc1c67de1a77e7b9bbd8e71808e1eaa..e10fbb8fb8d9d7d4b575df3928ed81e6117c9583 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -19,6 +19,8 @@ shadow-4.1.0 -> shadow-4.1.1                                          UNRELEASED
     passwd entry, but no shadow entry.
 - groupadd
   * New option -p/--password to specify an encrypted password.
+- groupmems
+  * Fix buffer overflow when adding an user to a group. Thanks to Peter Vrabec.
 - groupmod
   * New option -p/--password to specify an encrypted password.
 - grpck

diff --git a/src/groupmems.c b/src/groupmems.c
index 67cb77125acc40e03367237ef93f50f9c7d83620..4852e8651203a37ab586a4cb07a2b1bb25406c65 100644 (file)
--- a/src/groupmems.c
+++ b/src/groupmems.c
@@ -104,7 +104,7 @@ static void addtogroup (char *user, char **members)
                }
        }
 
-       members = (char **) realloc (members, sizeof (char *) * i);
+       members = (char **) realloc (members, sizeof (char *) * (i+2));
        members[i] = user;
        members[i + 1] = NULL;
 }