]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/hugetlb_cgroup: fix -Wformat-truncation warning
authorXiu Jianfeng <xiujianfeng@huawei.com>
Mon, 22 Dec 2025 07:23:59 +0000 (07:23 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 21 Jan 2026 03:24:48 +0000 (19:24 -0800)
A false-positive compile warnings with -Wformat-trucation was introduced
by commit 47179fe03588 ("mm/hugetlb_cgroup: prepare cftypes based on
template") on arch s390.  Suppress it by replacing snprintf() with
scnprintf().

mm/hugetlb_cgroup.c: In function 'hugetlb_cgroup_file_init':
mm/hugetlb_cgroup.c:829:44: warning: '%s' directive output may be truncated writing up to 1623 bytes into a region of size between 32 and 63 [-Wformat-truncation=]
  829 |   snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name);
      |                                            ^~

Link: https://lkml.kernel.org/r/20251222072359.3626182-1-xiujianfeng@huaweicloud.com
Fixes: 47179fe03588 ("mm/hugetlb_cgroup: prepare cftypes based on template")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202512212332.9lFRbgdS-lkp@intel.com/
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: "David Hildenbrand (Red Hat)" <david@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Oscar Salvador <osalvador@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb_cgroup.c

index 58e895f3899a1db365e35f47a1c1739b4a34e0b5..7144d7d555eb800fdcb0dc21341850d20b4d5432 100644 (file)
@@ -822,7 +822,7 @@ hugetlb_cgroup_cfttypes_init(struct hstate *h, struct cftype *cft,
        for (i = 0; i < tmpl_size; cft++, tmpl++, i++) {
                *cft = *tmpl;
                /* rebuild the name */
-               snprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name);
+               scnprintf(cft->name, MAX_CFTYPE_NAME, "%s.%s", buf, tmpl->name);
                /* rebuild the private */
                cft->private = MEMFILE_PRIVATE(idx, tmpl->private);
                /* rebuild the file_offset */