perfdhcp avalanche: added todo comments

diff --git a/src/bin/perfdhcp/avalanche_scen.cc b/src/bin/perfdhcp/avalanche_scen.cc
index 8db1098f9f83183155cfc3216fd6704941a8f42b..0681ea1133163d0aee6d1c101ae2bcbe3058de25 100644 (file)
--- a/src/bin/perfdhcp/avalanche_scen.cc
+++ b/src/bin/perfdhcp/avalanche_scen.cc
@@ -125,6 +125,10 @@ AvalancheScen::run() {
         usleep(100);
 
         now = microsec_clock::universal_time();
+        // Wait for 200ms between subsequent check for resending.
+        // This time taken based on experiments. For times 10-30ms whole scenario
+        // time significantly grows. The same for times >200ms. The optimal times
+        // are between 50-200ms. \todo more research is needed.
         if (now - prev_cycle_time > milliseconds(200)) { // check if 0.2s elapsed
             prev_cycle_time = now;
             int still_left_cnt = 0;

diff --git a/src/bin/perfdhcp/tests/basic_scen_unittest.cc b/src/bin/perfdhcp/tests/basic_scen_unittest.cc
index a3f2f553f1ee9edf4144fec4036754fc3f9a917d..24b743c79163fc0c5db48f47dab543ccf17dcb02 100644 (file)
--- a/src/bin/perfdhcp/tests/basic_scen_unittest.cc
+++ b/src/bin/perfdhcp/tests/basic_scen_unittest.cc
@@ -243,7 +243,7 @@ TEST_F(BasicScenTest, Packet4ExchangeMaxDrop10Proc) {
     // Use templates for this test.
     processCmdLine(opt, "perfdhcp -l fake -r 100 -R 20 -n 100"
                    " -D 10% -L 10547  -g single"
-                   // TODO: seems to be broken as it crashes building pkt
+                   // \todo seems to be broken as it crashes building pkt
                    // " -T " + getFullPath("discover-example.hex")
                    // + " -T " + getFullPath("request4-example.hex")
                    " 127.0.0.1");
@@ -289,7 +289,7 @@ TEST_F(BasicScenTest, Packet6ExchangeMaxDrop3Pkt) {
     // The maximum number of dropped packets is 3 (because of -D 3).
     processCmdLine(opt, "perfdhcp -l fake"
                    " -6 -r 100 -n 100 -R 20 -D 3 -L 10547"
-                   // TODO: seems to be broken as it crashes building pkt
+                   // \todo seems to be broken as it crashes building pkt
                    // " -T " + getFullPath("solicit-example.hex")
                    // + " -T " + getFullPath("request6-example.hex")
                    " ::1");

diff --git a/src/bin/perfdhcp/tests/command_options_unittest.cc b/src/bin/perfdhcp/tests/command_options_unittest.cc
index 3b0bc79b040e6d3830acee6193bb3cdb29ae1814..ef54afdaf75db4f0058850feb3b39306cdf9eea6 100644 (file)
--- a/src/bin/perfdhcp/tests/command_options_unittest.cc
+++ b/src/bin/perfdhcp/tests/command_options_unittest.cc
@@ -597,7 +597,7 @@ TEST_F(CommandOptionsTest, Offsets) {
     EXPECT_THROW(process(opt, "perfdhcp -6 -I -4 -l ethx all"),
                  isc::InvalidParameter);
 
-    // TODO - other negative cases
+    // \todo other negative cases
 }
 
 TEST_F(CommandOptionsTest, LocalPort) {