]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Use `textContent` instead of `innerText`. (#30462)
authorXhmikosR <xhmikosr@gmail.com>
Sun, 29 Mar 2020 06:53:57 +0000 (09:53 +0300)
committerGitHub <noreply@github.com>
Sun, 29 Mar 2020 06:53:57 +0000 (09:53 +0300)
It's supported by all of our supported browsers.

.eslintrc.json
js/src/tooltip.js
js/tests/unit/tooltip.spec.js

index 7ccce3214cfb26e2ecf8f25edb430d433ba28535..8c52318b47086f5f36997350ea3adaf94f412367 100644 (file)
@@ -48,7 +48,6 @@
     "unicorn/prefer-number-properties": "off",
     "unicorn/prefer-query-selector": "off",
     "unicorn/prefer-set-has": "off",
-    "unicorn/prefer-text-content": "off",
     "unicorn/prevent-abbreviations": "off"
   }
 }
index c493b15eebdb6ea695cfa5b22cb64d557850f222..9a1dff3d6e1dfffe154c023d2ad52dc3867ae6f0 100644 (file)
@@ -421,7 +421,7 @@ class Tooltip {
           element.appendChild(content)
         }
       } else {
-        element.innerText = content.textContent
+        element.textContent = content.textContent
       }
 
       return
@@ -434,7 +434,7 @@ class Tooltip {
 
       element.innerHTML = content
     } else {
-      element.innerText = content
+      element.textContent = content
     }
   }
 
index ed89315e0ba5d18df303a44693ab5cf00c6c8f20..5e3bb9326126a8f07aed9d89d0507b4b189063e9 100644 (file)
@@ -913,7 +913,7 @@ describe('Tooltip', () => {
 
       tooltip.setElementContent(tooltip.getTipElement(), 'test')
 
-      expect(tooltip.getTipElement().innerText).toEqual('test')
+      expect(tooltip.getTipElement().textContent).toEqual('test')
     })
   })