]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: milos: Sort pinctrl subnodes by pins
authorLuca Weiss <luca.weiss@fairphone.com>
Fri, 13 Feb 2026 14:03:19 +0000 (15:03 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 26 Mar 2026 14:40:32 +0000 (09:40 -0500)
As documented in the "Devicetree Sources (DTS) Coding Style" document,
pinctrl subnodes should be sorted by the pins property. Do this once for
milos.dtsi so that future additions can be added at the right places.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260213-milos-pinctrl-sort-v1-1-799bae597074@fairphone.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/milos.dtsi

index e1a51d43943ff4706c1a2722cae71afbceeed73d..bd9a11ea703dc802d9bb56d7fa58fd72011937d5 100644 (file)
 
                        wakeup-parent = <&pdc>;
 
+                       qup_spi0_data_clk: qup-spi0-data-clk-state {
+                               /* MISO, MOSI, CLK */
+                               pins = "gpio0", "gpio1", "gpio2";
+                               function = "qup0_se0";
+                               drive-strength = <6>;
+                               bias-disable;
+                       };
+
+                       qup_spi0_cs: qup-spi0-cs-state {
+                               pins = "gpio3";
+                               function = "qup0_se0";
+                               drive-strength = <6>;
+                               bias-disable;
+                       };
+
                        qup_i2c1_data_clk: qup-i2c1-data-clk-state {
                                /* SDA, SCL */
                                pins = "gpio4", "gpio5";
                                bias-pull-up = <2200>;
                        };
 
-                       qup_i2c7_data_clk: qup-i2c7-data-clk-state {
-                               /* SDA, SCL */
-                               pins = "gpio32", "gpio33";
-                               function = "qup1_se0";
-                               drive-strength = <2>;
-                               bias-pull-up;
-                       };
-
-                       qup_spi0_cs: qup-spi0-cs-state {
-                               pins = "gpio3";
-                               function = "qup0_se0";
-                               drive-strength = <6>;
-                               bias-disable;
-                       };
-
-                       qup_spi0_data_clk: qup-spi0-data-clk-state {
-                               /* MISO, MOSI, CLK */
-                               pins = "gpio0", "gpio1", "gpio2";
-                               function = "qup0_se0";
-                               drive-strength = <6>;
-                               bias-disable;
-                       };
-
                        qup_uart5_default: qup-uart5-default-state {
                                /* TX, RX */
                                pins = "gpio25", "gpio26";
                                bias-disable;
                        };
 
-                       qup_uart11_default: qup-uart11-default-state {
-                               /* TX, RX */
-                               pins = "gpio50", "gpio51";
-                               function = "qup1_se4";
+                       qup_i2c7_data_clk: qup-i2c7-data-clk-state {
+                               /* SDA, SCL */
+                               pins = "gpio32", "gpio33";
+                               function = "qup1_se0";
                                drive-strength = <2>;
                                bias-pull-up;
                        };
                                bias-pull-down;
                        };
 
+                       qup_uart11_default: qup-uart11-default-state {
+                               /* TX, RX */
+                               pins = "gpio50", "gpio51";
+                               function = "qup1_se4";
+                               drive-strength = <2>;
+                               bias-pull-up;
+                       };
+
                        sdc2_default: sdc2-default-state {
                                clk-pins {
                                        pins = "gpio62";