efi_loader: SetVariable() fix illegal return

We always have to return via EFI_EXIT() from EFIAPI functions.

Coverity reported an unreachable line and a resource leak.

Fixes: commit 6d2f27c5fd60 ("efi_loader: variable: support APPEND_WRITE")
Reported-by: Coverity Scan CID 253575, CID 184095
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

diff --git a/lib/efi_loader/efi_variable.c b/lib/efi_loader/efi_variable.c
index 48ee255f879b59fc9871d920e440fecd46f473d7..22ad271bd8524173522a3263862a30d9a0aafb46 100644 (file)
--- a/lib/efi_loader/efi_variable.c
+++ b/lib/efi_loader/efi_variable.c
@@ -470,7 +470,7 @@ efi_status_t EFIAPI efi_set_variable(u16 *variable_name,
 
                if (attributes & EFI_VARIABLE_APPEND_WRITE) {
                        if (!prefix(old_val, "(blob)")) {
-                               return EFI_DEVICE_ERROR;
+                               ret = EFI_DEVICE_ERROR;
                                goto out;
                        }
                        old_size = strlen(old_val);