]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/mellanox: mlxbf-tmfifo: fix vring_desc.len assignment
authorDavid Thompson <davthompson@nvidia.com>
Fri, 13 Jun 2025 21:46:08 +0000 (21:46 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 14:03:06 +0000 (16:03 +0200)
[ Upstream commit 109f4d29dade8ae5b4ac6325af9d1bc24b4230f8 ]

Fix warnings reported by sparse, related to incorrect type:
drivers/platform/mellanox/mlxbf-tmfifo.c:284:38: warning: incorrect type in assignment (different base types)
drivers/platform/mellanox/mlxbf-tmfifo.c:284:38:    expected restricted __virtio32 [usertype] len
drivers/platform/mellanox/mlxbf-tmfifo.c:284:38:    got unsigned long

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202404040339.S7CUIgf3-lkp@intel.com/
Fixes: 78034cbece79 ("platform/mellanox: mlxbf-tmfifo: Drop the Rx packet if no more descriptors")
Signed-off-by: David Thompson <davthompson@nvidia.com>
Link: https://lore.kernel.org/r/20250613214608.2250130-1-davthompson@nvidia.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/mellanox/mlxbf-tmfifo.c

index 39828eb84e0ba08835919c9fba4cf492287a5672..1015948ef43eb8ff86c4214aaf901821c5577644 100644 (file)
@@ -281,7 +281,8 @@ static int mlxbf_tmfifo_alloc_vrings(struct mlxbf_tmfifo *fifo,
                vring->align = SMP_CACHE_BYTES;
                vring->index = i;
                vring->vdev_id = tm_vdev->vdev.id.device;
-               vring->drop_desc.len = VRING_DROP_DESC_MAX_LEN;
+               vring->drop_desc.len = cpu_to_virtio32(&tm_vdev->vdev,
+                                                      VRING_DROP_DESC_MAX_LEN);
                dev = &tm_vdev->vdev.dev;
 
                size = vring_size(vring->num, vring->align);