]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virStorageBackendISCSISetAuth: Use g_strndup to '\0' terminate data
authorPeter Krempa <pkrempa@redhat.com>
Thu, 8 Dec 2022 10:18:34 +0000 (11:18 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 1 Feb 2023 08:16:17 +0000 (09:16 +0100)
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/storage/storage_backend_iscsi.c

index e4fa49d05f446a5d88fd9cb5f1181b583a8cc273..01900f6809318e418c5d393d689fe29eb530ce43 100644 (file)
@@ -283,10 +283,8 @@ virStorageBackendISCSISetAuth(const char *portal,
                                  &secret_value, &secret_size) < 0)
         return -1;
 
-    secret_str = g_new0(char, secret_size + 1);
-    memcpy(secret_str, secret_value, secret_size);
+    secret_str = g_strndup((char *) secret_value, secret_size);
     virSecureErase(secret_value, secret_size);
-    secret_str[secret_size] = '\0';
 
     if (virISCSINodeUpdate(portal,
                            source->devices[0].path,