pygpo: use correct method flags

The METH_KEYWORDS argument must always be combined with METH_VARARGS.

In Python up to 3.7 this was checked at runtime, and as we had no callers to
get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
import time, and everyone notices even if they aren't directly using GPOs.

Found and reported by Val Kulkov.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 12cccf3447333dfd4f5e437cd57ca5ec68724fdd)

diff --git a/libgpo/pygpo.c b/libgpo/pygpo.c
index 4db8cad7ca4b99e238eda40b770e157884c9c6a0..b8dfcd5572fcabc09c014a57ebc113395a3365e7 100644 (file)
--- a/libgpo/pygpo.c
+++ b/libgpo/pygpo.c
@@ -117,7 +117,7 @@ out:
 }
 
 static PyMethodDef GPO_methods[] = {
-       {"get_unix_path", (PyCFunction)py_gpo_get_unix_path, METH_KEYWORDS,
+       {"get_unix_path", (PyCFunction)py_gpo_get_unix_path, METH_VARARGS | METH_KEYWORDS,
                NULL },
        {NULL}
 };