]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/imagination: Load FW trace config at init
authorMatt Coster <matt.coster@imgtec.com>
Tue, 13 Jan 2026 10:16:41 +0000 (10:16 +0000)
committerMatt Coster <matt.coster@imgtec.com>
Mon, 19 Jan 2026 11:20:21 +0000 (11:20 +0000)
We have a module parameter to set the initial group mask before debugfs is
available for any specific device, but don't currently use that value when
initialising devices.

Use the module parameter value as the initial value for group_mask.

Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>
Link: https://patch.msgid.link/20260113-device-support-info-v1-3-91e5db7f7294@imgtec.com
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
drivers/gpu/drm/imagination/pvr_fw_trace.c

index a2aa588cbe5fae65bf997cc66c3f49d23483b95a..93119f0f23a921e35b9ad2957bc8c4ef2edac20f 100644 (file)
@@ -130,8 +130,13 @@ int pvr_fw_trace_init(struct pvr_device *pvr_dev)
                }
        }
 
-       /* TODO: Provide control of group mask. */
-       fw_trace->group_mask = 0;
+       /*
+        * Load the initial group_mask from the init_fw_trace_mask module
+        * parameter. This allows early tracing before the user can write to
+        * debugfs. Unlike update_logtype(), we don't set log_type here as that
+        * is initialised by tracebuf_ctrl_init().
+        */
+       fw_trace->group_mask = pvr_fw_trace_init_mask;
 
        fw_trace->tracebuf_ctrl =
                pvr_fw_object_create_and_map(pvr_dev,