]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
app-layer-ssl: handle all versions above TLSv1.2 as TLSv1.3
authorMats Klepsland <mats.klepsland@gmail.com>
Mon, 29 Oct 2018 19:30:41 +0000 (20:30 +0100)
committerMats Klepsland <mats.klepsland@gmail.com>
Mon, 29 Oct 2018 19:30:41 +0000 (20:30 +0100)
This makes it more likely to log custom versions of TLSv1.3 that
doesn't comply with the draft version numbering.

src/app-layer-ssl.c

index a3f3c5061fd42fa177dff781c3c84f53f75104c5..f46873bcb29f0f7a6c9a7de566b9257b7f656fa7 100644 (file)
@@ -946,7 +946,7 @@ static inline int TLSDecodeHSHelloExtensionSupportedVersions(SSLState *ssl_state
         uint16_t ver = *input << 8 | *(input + 1);
 
         if ((ssl_state->flags & SSL_AL_FLAG_CH_VERSION_EXTENSION) &&
-            ((ver == TLS_VERSION_13) || (((ver >> 8) & 0xff) == 0x7f))) {
+                (ver > TLS_VERSION_12)) {
             ssl_state->flags |= SSL_AL_FLAG_LOG_WITHOUT_CERT;
         }