]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
cve-check: hook cleanup to the BuildCompleted event, not CookerExit
authorRoss Burton <ross.burton@arm.com>
Wed, 29 Jun 2022 15:15:19 +0000 (16:15 +0100)
committerSteve Sakoman <steve@sakoman.com>
Tue, 5 Jul 2022 20:04:09 +0000 (10:04 -1000)
The cve-check class writes temporary files to preserve state across the
build, and cleans them up in a CookerExit handler.

However, in memory-resident builds the cooker won't exit in between
builds, so the state isn't cleared and the CVE report generation fails:

NOTE: Generating JSON CVE summary
ERROR: Error adding the same package twice

Easily solved by hooking to BuildCompleted, instead of CookerExit.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit fccdcfd301de281a427bfee48d8ff47fa07b7259)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/classes/cve-check.bbclass

index d0f6970db805666853cee432c4dd6e46b0a09350..1688fe2dfe77e60eb8d29f49191e88aab4de0940 100644 (file)
@@ -164,7 +164,7 @@ python cve_check_cleanup () {
 }
 
 addhandler cve_check_cleanup
-cve_check_cleanup[eventmask] = "bb.cooker.CookerExit"
+cve_check_cleanup[eventmask] = "bb.event.BuildCompleted"
 
 python cve_check_write_rootfs_manifest () {
     """