app_voicemail: Temp message left after review/hangup with ODBC/IMAP backend

When using ODBC or IMAP storage, temporary files created on the file system
must be disposed of using the DISPOSE macro. The DELETE macro will map to a
deletion function for the backend storage, but does not clean up any local
files created as a result of the operation.

When using voicemail with the operator and review options enabled, pressing
0 to enter the menu, followed by 1 to save the message, followed by any
other DTMF press to delete the message, will result in the temporary file
lingering on the file system.

This patch properly calls DISPOSE after the DELETE. This causes the local
file to be disposed of.

ASTERISK-24288 #close
Reported by: LEI FU
patches:
  voicemail_odbc_review_fix.diff uploaded by LEI FU (License 6640)

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@430795 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index 3743ec1d7d3e436917f3547a6a04368588df6e7a..c51d73ec5e6f6a6392858b123167a5217597587f 100644 (file)
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -14767,6 +14767,7 @@ static int play_record_review(struct ast_channel *chan, char *playfile, char *re
                                } else {
                                        ast_play_and_wait(chan, "vm-deleted");
                                        DELETE(tempfile, -1, tempfile, vmu);
+                                       DISPOSE(tempfile, -1);
                                        cmd = '0';
                                }
                        }