]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
hwmon/f71882fg: Set platform drvdata to NULL later
authorHans de Goede <hdegoede@redhat.com>
Sun, 13 Mar 2011 12:50:33 +0000 (13:50 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Mar 2011 19:49:50 +0000 (12:49 -0700)
commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream.

This avoids a possible race leading to trying to dereference NULL.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/hwmon/f71882fg.c

index 75afb3b0e0763c184a1b22cdc163ef32d10d2969..2855ef9ab287fd66d256c77891e55b5fd168e2a1 100644 (file)
@@ -2110,7 +2110,6 @@ static int f71882fg_remove(struct platform_device *pdev)
        int nr_fans = (data->type == f71882fg) ? 4 : 3;
        u8 start_reg = f71882fg_read8(data, F71882FG_REG_START);
 
-       platform_set_drvdata(pdev, NULL);
        if (data->hwmon_dev)
                hwmon_device_unregister(data->hwmon_dev);
 
@@ -2177,6 +2176,7 @@ static int f71882fg_remove(struct platform_device *pdev)
                }
        }
 
+       platform_set_drvdata(pdev, NULL);
        kfree(data);
 
        return 0;