]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
HID: Kconfig: Add LEDS_CLASS_MULTICOLOR dependency to HID_LOGITECH
authorKate Hsuan <hpa@redhat.com>
Tue, 11 Feb 2025 05:02:40 +0000 (13:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:49 +0000 (11:13 +0200)
[ Upstream commit 4465f4fa21e0e54c10896db3ed49dbd5a9aad3fd ]

The test bot found an issue with building hid-lg-g15.

All errors (new ones prefixed by >>):

   powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g510_kbd_led_write':
>> drivers/hid/hid-lg-g15.c:241:(.text+0x768): undefined reference to `led_mc_calc_color_components'
   powerpc-linux-ld: drivers/hid/hid-lg-g15.o: in function `lg_g15_register_led':
>> drivers/hid/hid-lg-g15.c:686:(.text+0xa9c): undefined reference to `devm_led_classdev_multicolor_register_ext'

Since multicolor LED APIs manage the keyboard backlight settings of
hid-lg-g15, the LEDS_CLASS_MULTICOLOR dependency was added to
HID_LOGITECH.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502110032.VZ0J024X-lkp@intel.com/
Fixes: a3a064146c50 ("HID: hid-lg-g15: Use standard multicolor LED API")
Signed-off-by: Kate Hsuan <hpa@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/Kconfig

index 4cfea399ebab2ded7391439969df01d3eee6a1bc..76be97c5fc2ff6e84e81d230b87dd99694b64372 100644 (file)
@@ -603,6 +603,7 @@ config HID_LOGITECH
        tristate "Logitech devices"
        depends on USB_HID
        depends on LEDS_CLASS
+       depends on LEDS_CLASS_MULTICOLOR
        default !EXPERT
        help
        Support for Logitech devices that are not fully compliant with HID standard.