]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
views: Avoid mutable default arguments
authorStephen Finucane <stephenfinucane@hotmail.com>
Sun, 4 Sep 2016 00:29:01 +0000 (01:29 +0100)
committerStephen Finucane <stephenfinucane@hotmail.com>
Wed, 7 Sep 2016 20:05:02 +0000 (21:05 +0100)
Signed-off-by: Stephen Finucane <stephenfinucane@hotmail.com>
patchwork/views/__init__.py

index ddddf634243d08305283f5fcc2863ac77798dbae..15695d669137a21035afbafdf1f774a0b73cc733 100644 (file)
@@ -185,9 +185,12 @@ def set_bundle(request, project, action, data, patches, context):
     return []
 
 
-def generic_list(request, project, view,
-                 view_args={}, filter_settings=[], patches=None,
-                 editable_order=False):
+def generic_list(request, project, view, view_args=None, filter_settings=None,
+                 patches=None, editable_order=False):
+
+    if not filter_settings:
+        filter_settings = []
+
     filters = Filters(request)
     context = {
         'project': project,
@@ -220,7 +223,7 @@ def generic_list(request, project, view,
         'order': order,
         'list_view': {
             'view': view,
-            'view_params': view_args,
+            'view_params': view_args or {},
             'params': params
         }})