firmware: imx: scu-irq: fix OF node leak in

imx_scu_enable_general_irq_channel() calls of_parse_phandle_with_args(),
but does not release the OF node reference. Add a of_node_put() call
to release the reference.

Fixes: 851826c7566e ("firmware: imx: enable imx scu general irq function")
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

diff --git a/drivers/firmware/imx/imx-scu-irq.c b/drivers/firmware/imx/imx-scu-irq.c
index 6125cccc9ba79cd3445a720935b5c0b276c83d73..f2b902e95b738fae90af9cbe54da4f488219906f 100644 (file)
--- a/drivers/firmware/imx/imx-scu-irq.c
+++ b/drivers/firmware/imx/imx-scu-irq.c
@@ -226,8 +226,10 @@ int imx_scu_enable_general_irq_channel(struct device *dev)
        INIT_WORK(&imx_sc_irq_work, imx_scu_irq_work_handler);
 
        if (!of_parse_phandle_with_args(dev->of_node, "mboxes",
-                                      "#mbox-cells", 0, &spec))
+                                      "#mbox-cells", 0, &spec)) {
                i = of_alias_get_id(spec.np, "mu");
+               of_node_put(spec.np);
+       }
 
        /* use mu1 as general mu irq channel if failed */
        if (i < 0)