]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: block-commit: Mark disk in block jobs only on successful command
authorPeter Krempa <pkrempa@redhat.com>
Mon, 16 Mar 2015 15:52:44 +0000 (16:52 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 16 Mar 2015 16:21:13 +0000 (17:21 +0100)
Patch 51f9f03a4ca50b070c0fbfb29748d49f583e15e1 introduces a regression
where if a blockCommit operation fails the disk is still marked as being
part of a block job but can't be unmarked later.

src/qemu/qemu_driver.c

index 149963f0562d7d6e51fbc549e5011bc7e2dad882..f4b8dab69786aa09cef6fb2b2ebb51d4e508bbaa 100644 (file)
@@ -17094,7 +17094,8 @@ qemuDomainBlockCommit(virDomainPtr dom,
         goto endjob;
     }
 
-    disk->blockjob = true;
+    if (ret == 0)
+        disk->blockjob = true;
 
     if (mirror) {
         if (ret == 0) {