]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: light: al3010: read both ALS ADC registers again
authorAlexander A. Klimov <grandmaster@al2klimov.de>
Sat, 23 May 2026 11:44:57 +0000 (13:44 +0200)
committerJonathan Cameron <jic23@kernel.org>
Tue, 26 May 2026 18:22:57 +0000 (19:22 +0100)
al3010_read_raw() used to read two adjacent registers
until the driver was modernized using the regmap framework.
That cleanup accidentally replaced the 16-bit word read
with a single byte read. I'm reverting latter.

Fixes: 0e5e21e23dd6 ("iio: light: al3010: Implement regmap support")
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/light/al3010.c

index 0932fa2b49fa7cd99f10c7b4dbbbb51f111618c6..6af7b5f14a31120ad3f5c1a5afd86e20db7626c0 100644 (file)
@@ -111,7 +111,8 @@ static int al3010_read_raw(struct iio_dev *indio_dev,
                           int *val2, long mask)
 {
        struct al3010_data *data = iio_priv(indio_dev);
-       int ret, gain, raw;
+       int ret, gain;
+       __le16 raw;
 
        switch (mask) {
        case IIO_CHAN_INFO_RAW:
@@ -120,11 +121,12 @@ static int al3010_read_raw(struct iio_dev *indio_dev,
                 * - low byte of output is stored at AL3010_REG_DATA_LOW
                 * - high byte of output is stored at AL3010_REG_DATA_LOW + 1
                 */
-               ret = regmap_read(data->regmap, AL3010_REG_DATA_LOW, &raw);
+               ret = regmap_bulk_read(data->regmap, AL3010_REG_DATA_LOW,
+                                      &raw, sizeof(raw));
                if (ret)
                        return ret;
 
-               *val = raw;
+               *val = le16_to_cpu(raw);
 
                return IIO_VAL_INT;
        case IIO_CHAN_INFO_SCALE: