]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/ttm: Make ttm_bo_init_validate safe against ttm_operation_ctx re-ordering
authorTvrtko Ursulin <tvrtko.ursulin@igalia.com>
Fri, 19 Sep 2025 13:15:27 +0000 (14:15 +0100)
committerTvrtko Ursulin <tursulin@ursulin.net>
Wed, 3 Dec 2025 14:48:06 +0000 (14:48 +0000)
Struct ttm_operation_ctx initializer in ttm_bo_init_validate assumes the
order of the structure fields when it is configuring the interruptible
flag.

Fix it by using named initialization.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Tvrtko Ursulin <tursulin@ursulin.net>
Link: https://lore.kernel.org/r/20250919131530.91247-2-tvrtko.ursulin@igalia.com
drivers/gpu/drm/ttm/ttm_bo.c

index bd27607f8076b3870f5f9c9c9261471c3db3ff80..1df487425e968d6c268100640d31b966b68a3f21 100644 (file)
@@ -1027,7 +1027,7 @@ int ttm_bo_init_validate(struct ttm_device *bdev, struct ttm_buffer_object *bo,
                         struct sg_table *sg, struct dma_resv *resv,
                         void (*destroy) (struct ttm_buffer_object *))
 {
-       struct ttm_operation_ctx ctx = { interruptible, false };
+       struct ttm_operation_ctx ctx = { .interruptible = interruptible };
        int ret;
 
        ret = ttm_bo_init_reserved(bdev, bo, type, placement, alignment, &ctx,