]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "drm/syncobj: Fix handle <-> fd ioctls with dirty stack"
authorMaarten Lankhorst <dev@lankhorst.se>
Thu, 5 Mar 2026 11:37:34 +0000 (12:37 +0100)
committerMaarten Lankhorst <dev@lankhorst.se>
Thu, 5 Mar 2026 14:16:48 +0000 (15:16 +0100)
This reverts commit 2e3649e237237258a08d75afef96648dd2b379f7.

The problem occurs when userspace is compiled against new headers
with new members, but don't correctly initialise those new members.

This is not a kernel problem, and should be fixed in userspace by
correctly zero'ing all members.

Cc: Rob Clark <robdclark@chromium.org>
Cc: Julian Orth <ju.orth@gmail.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Michel Dänzer <michel.daenzer@mailbox.org>
Reviewed-by: Christian König <christian.koenig@amd.com>
Acked-by: Julian Orth <ju.orth@gmail.com>
Link: https://patch.msgid.link/20260305113734.1309238-1-dev@lankhorst.se
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
drivers/gpu/drm/drm_syncobj.c

index 49eccb43ce63d7441fd9fb1181a058a766d10536..250734dee928ed38d865b5bbfe24a9e950e90912 100644 (file)
@@ -875,7 +875,7 @@ drm_syncobj_handle_to_fd_ioctl(struct drm_device *dev, void *data,
                return drm_syncobj_export_sync_file(file_private, args->handle,
                                                    point, &args->fd);
 
-       if (point)
+       if (args->point)
                return -EINVAL;
 
        return drm_syncobj_handle_to_fd(file_private, args->handle,
@@ -909,7 +909,7 @@ drm_syncobj_fd_to_handle_ioctl(struct drm_device *dev, void *data,
                                                          args->handle,
                                                          point);
 
-       if (point)
+       if (args->point)
                return -EINVAL;
 
        return drm_syncobj_fd_to_handle(file_private, args->fd,