patch 8.1.0436: can get the text of inputsecret() with getcmdline()

Problem:    Can get the text of inputsecret() with getcmdline(). (Tommy Allen)
Solution:   Don't return the text.

diff --git a/src/ex_getln.c b/src/ex_getln.c
index f08ae903261008f82fd188e9e39754d71aaa8cf3..02c3e3009544d0b6d31ad20bd6dfd658dacf14f7 100644 (file)
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -1310,7 +1310,7 @@ getcmdline(
            if (c != Ctrl_N && c != Ctrl_G && (c != 'e'
                                    || (ccline.cmdfirstc == '=' && KeyTyped)
 #ifdef FEAT_EVAL
-                                   || cmdline_star
+                                   || cmdline_star > 0
 #endif
                                    ))
            {
@@ -1805,8 +1805,8 @@ getcmdline(
                new_cmdpos = -1;
                if (c == '=')
                {
-                   if (ccline.cmdfirstc == '=' // can't do this recursively
-                           || cmdline_star)    // or when typing a password
+                   if (ccline.cmdfirstc == '='  // can't do this recursively
+                           || cmdline_star > 0) // or when typing a password
                    {
                        beep_flush();
                        c = ESC;
@@ -6506,8 +6506,11 @@ get_ccline_ptr(void)
     char_u *
 get_cmdline_str(void)
 {
-    struct cmdline_info *p = get_ccline_ptr();
+    struct cmdline_info *p;
 
+    if (cmdline_star > 0)
+       return NULL;
+    p = get_ccline_ptr();
     if (p == NULL)
        return NULL;
     return vim_strnsave(p->cmdbuff, p->cmdlen);

diff --git a/src/version.c b/src/version.c
index d3b09ea4bf8cf8500313ccd449cdc0dab0ed35ae..7f21f2d8099e91ed7b6cd4e9ba6b5f2f4661095e 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -794,6 +794,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    436,
 /**/
     435,
 /**/