]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
OWE: Fix SSID comparison in transition mode case
authorVinayak Yadawad <vinayak.yadawad@broadcom.com>
Fri, 13 Dec 2024 08:45:27 +0000 (14:15 +0530)
committerJouni Malinen <j@w1.fi>
Thu, 26 Dec 2024 17:54:47 +0000 (19:54 +0200)
ret_ssid is a pointer to a pointer to the SSID and as such, it needs to
be referenced once here for the comparison just like ret_ssid_len. This
was broken recently as a part of duplicated code removal.

Fixes: ddfed3f08473 ("OWE: Reduce code duplication in OWE element parsing")
Signed-off-by: Vinayak Yadawad <vinayak.yadawad@broadcom.com>
wpa_supplicant/events.c

index 00109a0cd7801ace1cac682b86ffab6df5c2d04b..279838afa2bf9fdef626831b0eecc9d921f9d990 100644 (file)
@@ -1162,7 +1162,8 @@ static void owe_trans_ssid(struct wpa_supplicant *wpa_s, struct wpa_bss *bss,
                        if (wpas_network_disabled(wpa_s, ssid))
                                continue;
                        if (ssid->ssid_len == *ret_ssid_len &&
-                           os_memcmp(ssid->ssid, ret_ssid, *ret_ssid_len) == 0) {
+                           os_memcmp(ssid->ssid, *ret_ssid, *ret_ssid_len) ==
+                           0) {
                                /* OWE BSS in transition mode for a currently
                                 * enabled OWE network. */
                                wpa_dbg(wpa_s, MSG_DEBUG,