]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:libsmb: Check return code of cli_credentials_guess()
authorAndreas Schneider <asn@samba.org>
Tue, 22 Jun 2021 07:35:47 +0000 (09:35 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 29 Jun 2021 02:19:35 +0000 (02:19 +0000)
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/libsmb/auth_generic.c

index 59560d677bc2aba7710d236828de8902e8137e9c..e5120a083a656f2b97913a9cae85f5c2936d8f22 100644 (file)
@@ -64,6 +64,7 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
        struct gensec_settings *gensec_settings;
        const struct gensec_security_ops **backends = NULL;
        struct loadparm_context *lp_ctx;
+       bool ok;
 
        ans = talloc_zero(mem_ctx, struct auth_generic_state);
        if (!ans) {
@@ -120,7 +121,11 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
                return NT_STATUS_NO_MEMORY;
        }
 
-       cli_credentials_guess(ans->credentials, lp_ctx);
+       ok = cli_credentials_guess(ans->credentials, lp_ctx);
+       if (!ok) {
+               TALLOC_FREE(ans);
+               return NT_STATUS_INTERNAL_ERROR;
+       }
 
        talloc_unlink(ans, lp_ctx);
        talloc_unlink(ans, gensec_settings);