bugfix #697: Double free with ldns-dane create

Thanks Carsten Strotmann

diff --git a/Changelog b/Changelog
index 0b2b160d024cbce2a709bd75e673f2afdaba1cef..4e350ba2d89dbb7225156408d817dfffefa7e332 100644 (file)
--- a/Changelog
+++ b/Changelog
@@ -34,6 +34,8 @@ TBD
          terminals.  Thanks Stuart Browne
        * bugfix #605: Determine default trust anchor location at compile time
          Thanks Peter Koch
+       * bugfix #697: Double free with ldns-dane create
+         Thanks Carsten Strotmann
 
 1.6.17 2014-01-10
        * Fix ldns_dnssec_zone_new_frm_fp_l to allow the last parsed line of a

diff --git a/examples/ldns-dane.c b/examples/ldns-dane.c
index d35099be055923ec0eb4b58c573c15d827c1e6c9..8d8c2749ea6ac171a05371bc178a6fe063fd98d3 100644 (file)
--- a/examples/ldns-dane.c
+++ b/examples/ldns-dane.c
@@ -1071,7 +1071,7 @@ dane_create(ldns_rr_list* tlsas, ldns_rdf* tlsa_owner,
                        selected_cert);
        LDNS_ERR(s, "could not create tlsa rr");
 
-       ldns_rr_set_owner(tlsa_rr, tlsa_owner);
+       ldns_rr_set_owner(tlsa_rr, ldns_rdf_clone(tlsa_owner));
                             
        if (! ldns_rr_list_contains_rr(tlsas, tlsa_rr)) {
                if (! ldns_rr_list_push_rr(tlsas, tlsa_rr)) {