res_pjsip_mwi: Fix memory leak of MWI subscriptions container

This patch fixes a reference counting memory leak on the ao2_container
created as part of create_mwi_subscriptions. When we create the container
in this routine, the intent is to hand lifetime ownership over to the global
container unsolicited_mwi. When ao2_global_obj_replace_unref is called, the
reference count on mwi_subscriptions (the container) will be bumped by 1;
however, the function does not decrement the reference count on
mwi_subscriptions when this occurs. This will prevent the container from being
fully disposed of when Asterisk exits (or on any subsequent call to this
operation, such as during a reload).

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/12@402940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/res/res_pjsip_mwi.c b/res/res_pjsip_mwi.c
index 6bed363927aa94756f5d48fdc3a760cf543043b6..bd865eec4c4f44a6e999e02e4406e7bc4c1084d6 100644 (file)
--- a/res/res_pjsip_mwi.c
+++ b/res/res_pjsip_mwi.c
@@ -682,6 +682,7 @@ static void create_mwi_subscriptions(void)
        }
        ao2_callback(endpoints, OBJ_NODATA, create_mwi_subscriptions_for_endpoint, mwi_subscriptions);
        ao2_global_obj_replace_unref(unsolicited_mwi, mwi_subscriptions);
+       ao2_ref(mwi_subscriptions, -1);
 }
 
 static int reload(void)