Fix a typo in the plugins2 README.BRANCH file and flesh out the

"what's wrong with" section a bit.

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/plugins2@24204 dc483132-0cff-0310-8789-dd5450dbe970

diff --git a/README.BRANCH b/README.BRANCH
index b5ee7f71b8e6de9590f769a75d8aecc6125c8a00..02af723c1fb90dd6b8eb94d75b97e355d0518be1 100644 (file)
--- a/README.BRANCH
+++ b/README.BRANCH
@@ -14,7 +14,7 @@ disabling modules by name.
 
 The profile schema used in this branch is:
 
-  [preauth]
+  [plugins]
   interfacename = {
     # May take multiple values; only named plugins will be enabled.
     enable_only = name
@@ -173,3 +173,26 @@ demonstration branch it is not perfect.  Problems include:
   type are kind of haphazard, erring on the side of using typedefs.
 
 * The Hesiod support in server_misc.c was ripped out.
+
+* The framework does not allow built-in modules to be registered for a
+  pluggable interface after the first load operation for that
+  interface.  This constraint is probably fine, but if it needs to be
+  revisited, the framework's data model will need to be made a little
+  more complicated to allow it.
+
+* For brevity, vtable constructor functions are called "init"
+  functions in the code.  That name may be too vague, and may fool
+  module implementors into thinking the init function is responsible
+  for more than just vtable construction (such as the initialization
+  of private module data).  This may need to be renamed to something
+  more specific like "initvt".
+
+* The pwqual vtable declarations put function signatures directly into
+  the vtable structure definition, with comments describing each
+  function's contract alongside the signature.  This is consistent
+  with how the existing DAL pluggable interface is declared.  An
+  alternative would be to create typedefs for each function signature
+  and place the comments describing the function contract with the
+  typedefs.  The vtable definition would then be very concise, with
+  only one line per method.  This would be consistent with how the
+  existing preauth pluggable interfaces are declared.