]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
smb: client: fix noisy when tree connecting to DFS interlink targets
authorPaulo Alcantara <pc@manguebit.com>
Wed, 5 Feb 2025 16:22:11 +0000 (13:22 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:15 +0000 (12:54 -0700)
[ Upstream commit 773dc23ff81838b6f74d7fabba5a441cc6a93982 ]

When the client attempts to tree connect to a domain-based DFS
namespace from a DFS interlink target, the server will return
STATUS_BAD_NETWORK_NAME and the following will appear on dmesg:

CIFS: VFS:  BAD_NETWORK_NAME: \\dom\dfs

Since a DFS share might contain several DFS interlinks and they expire
after 10 minutes, the above message might end up being flooded on
dmesg when mounting or accessing them.

Print this only once per share.

Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/smb/client/smb2pdu.c

index 2e3f78fe9210ffcc923bb9a64bf065367dcd710b..89a9b8ffe9d9260f521e81c68bb6a5af8dc7f026 100644 (file)
@@ -2175,7 +2175,7 @@ tcon_exit:
 
 tcon_error_exit:
        if (rsp && rsp->hdr.Status == STATUS_BAD_NETWORK_NAME)
-               cifs_tcon_dbg(VFS, "BAD_NETWORK_NAME: %s\n", tree);
+               cifs_dbg(VFS | ONCE, "BAD_NETWORK_NAME: %s\n", tree);
        goto tcon_exit;
 }