]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
opp: remove WARN when no valid OPPs remain
authorMichał Mirosław <mirq-linux@rere.qmqm.pl>
Mon, 26 Jul 2021 08:30:56 +0000 (10:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Sep 2021 08:23:00 +0000 (10:23 +0200)
[ Upstream commit 335ffab3ef864539e814b9a2903b0ae420c1c067 ]

This WARN can be triggered per-core and the stack trace is not useful.
Replace it with plain dev_err(). Fix a comment while at it.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/opp/of.c

index c582a9ca397bb4ab6f8b8344240fe5060d6bdd0e..01feeba78426cbdb3a9e716c3f3f665ddd668121 100644 (file)
@@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
                }
        }
 
-       /* There should be one of more OPP defined */
-       if (WARN_ON(!count)) {
+       /* There should be one or more OPPs defined */
+       if (!count) {
+               dev_err(dev, "%s: no supported OPPs", __func__);
                ret = -ENOENT;
                goto remove_static_opp;
        }