]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_FD_PASSING
authorPeter Krempa <pkrempa@redhat.com>
Wed, 16 Feb 2022 15:26:31 +0000 (16:26 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 17 Feb 2022 12:15:46 +0000 (13:15 +0100)
The feature implies that fd passing works with RPC. Non-remote impls
thus should always report support.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/driver.c

index bcf5db599868170a3fc0867d9c115494a4b3019d..41b4f0055b1a3ee81beafc0655d49ac9132a5d6d 100644 (file)
@@ -362,10 +362,14 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
      * thus use the correct ordering with an updated server. All drivers must
      * signal support for this feature. */
     case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER:
+    /* The remote driver intercepts and always reports the feature since it was
+     * introduced. This means that all driver implementations should advertise
+     * it too as it works natively without RPC. Always enabling this will also
+     * prevent regressions when a driver is used in embedded mode */
+    case VIR_DRV_FEATURE_FD_PASSING:
         *supported = 1;
         return true;
 
-    case VIR_DRV_FEATURE_FD_PASSING:
     case VIR_DRV_FEATURE_MIGRATION_V2:
     case VIR_DRV_FEATURE_MIGRATION_V3:
     case VIR_DRV_FEATURE_MIGRATION_P2P: