qemu: capabilities: Note that basing probing on 'query-command-line-options' should...

Add a comment that will attempt to discourage adding new capabilities
based on 'query-command-line-options'.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index adb15a89f264a833449460c3ebd7c22eca06180f..4b303b660df36b4ba32c6bceed98cf0ceeeaef5b 100644 (file)
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3221,6 +3221,10 @@ struct virQEMUCapsCommandLineProps {
     int flag;
 };
 
+
+/* This uses 'query-command-line-options' which uses old-style argument parsers
+ * in qemu and thus isn't being properly extended. Other means to detect
+ * features should be used if possible. */
 static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] = {
     { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT },
     { "boot-opts", "reboot-timeout", QEMU_CAPS_REBOOT_TIMEOUT },