fixed splint test on open

added some typecasts for splint (original writer: please check for possible dataloss)

diff --git a/keys.c b/keys.c
index 5b08d59971e421dcd9b1c3fd4f4804509f2cacaf..ae5cedf046f8ee45a75644a02198bcd3b91ac94d 100644 (file)
--- a/keys.c
+++ b/keys.c
@@ -286,21 +286,21 @@ static bool
 ldns_key_rsa2bin(unsigned char *data, RSA *k, uint16_t *size)
 {
         if (BN_num_bytes(k->e) < 256) {
-                data[0] = BN_num_bytes(k->e);
+                data[0] = (unsigned char) BN_num_bytes(k->e);
 
                 BN_bn2bin(k->e, data + 1);  
                 BN_bn2bin(k->n, data + *(data + 1) + 2);
         } else if (BN_num_bytes(k->e) < 65536) {
                 data[0] = 0;
                /* this writing is not endian save or is it? */
-               write_uint16(data + 1, BN_num_bytes(k->e));
+               write_uint16(data + 1, (uint16_t) BN_num_bytes(k->e));
 
                 BN_bn2bin(k->e, data + 3);
                 BN_bn2bin(k->n, data + 4 + BN_num_bytes(k->e));
        } else {
                return false;
        }
-       *size = BN_num_bytes(k->n) + 4;
+       *size = (uint16_t) BN_num_bytes(k->n) + 4;
        return true;
 }
 
@@ -310,7 +310,7 @@ ldns_key_dsa2bin(unsigned char *data, DSA *k, uint16_t *size)
        uint8_t T;
 
        /* See RFC2536 */
-       T = (DSA_size(k) - 512) / 64;
+       T = (uint8_t) ((DSA_size(k) - 512) / 64);
        memcpy(data, &T, 1);
 
        *size = 64 + (T * 8); 

diff --git a/rr.c b/rr.c
index 97f5b4ccd0820f230d50124b856398d486463e38..64dfb18640f23c27d74bd0802ecc179aeee2fceb 100644 (file)
--- a/rr.c
+++ b/rr.c
@@ -61,7 +61,7 @@ ldns_rr_new_frm_type(ldns_rr_type t)
        desc = ldns_rr_descript(t);
 
        printf("min %d\n",
-                       ldns_rr_descriptor_minimum(desc));
+                       (int) ldns_rr_descriptor_minimum(desc));
        
        rr->_rdata_fields = XMALLOC(ldns_rdf *, 
                        ldns_rr_descriptor_minimum(desc) - 1);