]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
pgsql: use generic name for TerminationMessage msg 12948/head
authorJuliana Fajardini <jufajardini@oisf.net>
Fri, 4 Apr 2025 21:34:26 +0000 (14:34 -0700)
committerVictor Julien <victor@inliniac.net>
Sat, 5 Apr 2025 06:11:39 +0000 (08:11 +0200)
Since this structure can be used for different messages with other
meanings.

Related to
Task #4854

rust/src/pgsql/logger.rs
rust/src/pgsql/parser.rs

index 7fb334365431ba00cd94b67c8db541ce61693d1a..ae281014315694fce83d991890c07c59bd9be6f5 100644 (file)
@@ -102,7 +102,7 @@ fn log_request(req: &PgsqlFEMessage, flags: u32) -> Result<JsonBuilder, JsonErro
             js.set_uint("process_id", *pid)?;
             js.set_uint("secret_key", *backend_key)?;
         }
-        PgsqlFEMessage::Terminate(TerminationMessage {
+        PgsqlFEMessage::Terminate(NoPayloadMessage {
             identifier: _,
             length: _,
         }) => {
index 034d3bf2e863878c700a9afbe52b6c48dac8a87e..2bddbb11387498054696e1430f7256cab09373bc 100644 (file)
@@ -278,7 +278,7 @@ pub struct CopyOutResponse {
 }
 
 #[derive(Debug, PartialEq, Eq)]
-pub struct TerminationMessage {
+pub struct NoPayloadMessage {
     pub identifier: u8,
     pub length: u32,
 }
@@ -300,7 +300,7 @@ pub enum PgsqlBEMessage {
     CommandComplete(RegularPacket),
     CopyOutResponse(CopyOutResponse),
     ConsolidatedCopyDataOut(ConsolidatedDataRowPacket),
-    CopyDone(TerminationMessage),
+    CopyDone(NoPayloadMessage),
     ReadyForQuery(ReadyForQueryMessage),
     RowDescription(RowDescriptionMessage),
     ConsolidatedDataRow(ConsolidatedDataRowPacket),
@@ -384,7 +384,7 @@ pub enum PgsqlFEMessage {
     SASLResponse(RegularPacket),
     SimpleQuery(RegularPacket),
     CancelRequest(CancelRequestMessage),
-    Terminate(TerminationMessage),
+    Terminate(NoPayloadMessage),
     UnknownMessageType(RegularPacket),
 }
 
@@ -776,7 +776,7 @@ fn parse_terminate_message(i: &[u8]) -> IResult<&[u8], PgsqlFEMessage, PgsqlPars
     let (i, length) = parse_exact_length(i, PGSQL_LENGTH_FIELD)?;
     Ok((
         i,
-        PgsqlFEMessage::Terminate(TerminationMessage { identifier, length }),
+        PgsqlFEMessage::Terminate(NoPayloadMessage { identifier, length }),
     ))
 }
 
@@ -1066,7 +1066,7 @@ fn parse_copy_done(i: &[u8]) -> IResult<&[u8], PgsqlBEMessage, PgsqlParseError<&
     let (i, identifier) = verify(be_u8, |&x| x == b'c')(i)?;
     let (i, length) = parse_exact_length(i, PGSQL_LENGTH_FIELD)?;
     Ok((
-        i, PgsqlBEMessage::CopyDone(TerminationMessage {
+        i, PgsqlBEMessage::CopyDone(NoPayloadMessage {
             identifier,
             length
         })