dynamic memory allocation i added a month ago: forgot to ZERO_STRUCT()

some of the server-side stuff.  Realloc() was being used, so it
Realloc()d some random area of memory.  oops.dynamic memory allocation i added a month ago: forgot to ZERO_STRUCT()
some of the server-side stuff.  Realloc() was being used, so it
Realloc()d some random area of memory.  oops.dynamic memory allocation i added a month ago: forgot to ZERO_STRUCT()
some of the server-side stuff.  Realloc() was being used, so it
Realloc()d some random area of memory.  oops.
(This used to be commit a51f62f4cf610c23e45251cedb543144747a3e54)

diff --git a/source3/rpc_parse/parse_samr.c b/source3/rpc_parse/parse_samr.c
index c50a883ca1135369d1c7b9ce53abf64b6a1a6be5..dad9d412e17f7ac2566cc5ccefb8e6df929b502d 100644 (file)
--- a/source3/rpc_parse/parse_samr.c
+++ b/source3/rpc_parse/parse_samr.c
@@ -3843,6 +3843,8 @@ BOOL make_samr_r_lookup_rids(SAMR_R_LOOKUP_RIDS *r_u,
                for (i = 0; i < num_names; i++)
                {
                        int len = name[i] != NULL ? strlen(name[i]) : 0;
+                       DEBUG(10,("name[%d]:%s\ttype:%d\n",
+                                  i, name[i], type[i]));
                        make_uni_hdr(&(r_u->hdr_name[i]), len);
                        make_unistr2(&(r_u->uni_name[i]), name[i], len);
                        r_u->type[i] = type[i];

diff --git a/source3/rpc_server/srv_samr.c b/source3/rpc_server/srv_samr.c
index e55a6b2ce866bf7990aaec43d3e35c8cda5d66c0..bc3a842677b924de52b0c8b123c5667056a334bd 100644 (file)
--- a/source3/rpc_server/srv_samr.c
+++ b/source3/rpc_server/srv_samr.c
@@ -1432,6 +1432,7 @@ static void samr_reply_query_useraliases(SAMR_Q_QUERY_USERALIASES *q_u,
 static void api_samr_query_useraliases( pipes_struct *p, prs_struct *data, prs_struct *rdata)
 {
        SAMR_Q_QUERY_USERALIASES q_u;
+       ZERO_STRUCT(q_u);
        samr_io_q_query_useraliases("", &q_u, data, 0);
        samr_reply_query_useraliases(&q_u, rdata);
        samr_free_q_query_useraliases(&q_u);
@@ -1797,6 +1798,7 @@ static void samr_reply_lookup_rids(SAMR_Q_LOOKUP_RIDS *q_u,
 static void api_samr_lookup_rids( pipes_struct *p, prs_struct *data, prs_struct *rdata)
 {
        SAMR_Q_LOOKUP_RIDS q_u;
+       ZERO_STRUCT(q_u);
        samr_io_q_lookup_rids("", &q_u, data, 0);
        samr_reply_lookup_rids(&q_u, rdata);
        samr_free_q_lookup_rids(&q_u);