Bug 347707: Changing parameters could silently fail because we weren't correctly

 checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 11ffe4d9ac9bc922fdd6fdd02b06895d077956ab..68e88814d7fee05def932fe1e82b309304094080 100644 (file)
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -272,7 +272,7 @@ sub write_params {
     close $fh;
 
     rename $tmpname, $param_file
-      || die "Can't rename $tmpname to $param_file: $!";
+      or die "Can't rename $tmpname to $param_file: $!";
 
     ChmodDataFile($param_file, 0666);