]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
security: apparmor: use automatic cleanup in load_profile
authorJán Tomko <jtomko@redhat.com>
Mon, 13 Dec 2021 13:06:17 +0000 (14:06 +0100)
committerJán Tomko <jtomko@redhat.com>
Mon, 13 Dec 2021 17:20:46 +0000 (18:20 +0100)
Use g_auto for virCommand and char * and drop the cleanup label.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/security/security_apparmor.c

index dadcfd67db33caae1cdc5412531604ac6cf1f9f9..d1087aa10cf8677936c0a1364e82526dabb7feae 100644 (file)
@@ -163,14 +163,13 @@ load_profile(virSecurityManager *mgr G_GNUC_UNUSED,
              const char *fn,
              bool append)
 {
-    int rc = -1;
     bool create = true;
-    char *xml = NULL;
-    virCommand *cmd = NULL;
+    g_autofree char *xml = NULL;
+    g_autoptr(virCommand) cmd = NULL;
 
     xml = virDomainDefFormat(def, NULL, VIR_DOMAIN_DEF_FORMAT_SECURE);
     if (!xml)
-        goto cleanup;
+        return -1;
 
     if (profile_status_file(profile) >= 0)
         create = false;
@@ -191,13 +190,7 @@ load_profile(virSecurityManager *mgr G_GNUC_UNUSED,
                            virLogGetDefaultPriority());
 
     virCommandSetInputBuffer(cmd, xml);
-    rc = virCommandRun(cmd, NULL);
-
- cleanup:
-    VIR_FREE(xml);
-    virCommandFree(cmd);
-
-    return rc;
+    return virCommandRun(cmd, NULL);
 }
 
 static int