ipproto: fix memleak in error case

diff --git a/src/detect-ipproto.c b/src/detect-ipproto.c
index 0eba42e6ca8778e46964e6bad1a58bafc1a2e2ed..f641f4520d519a811d2efbc5a3782c5a2deffd76 100644 (file)
--- a/src/detect-ipproto.c
+++ b/src/detect-ipproto.c
@@ -184,12 +184,11 @@ static int DetectIPProtoTypePresentForOP(Signature *s, uint8_t op)
 static int DetectIPProtoSetup(DetectEngineCtx *de_ctx, Signature *s, const char *optstr)
 {
     SigMatch *sm = NULL;
-    DetectIPProtoData *data = NULL;
     int i;
 
-    data = DetectIPProtoParse(optstr);
+    DetectIPProtoData *data = DetectIPProtoParse(optstr);
     if (data == NULL) {
-        goto error;
+        return -1;
     }
 
     /* Reset our "any" (or "ip") state: for ipv4, ipv6 and ip cases, the bitfield
@@ -422,6 +421,7 @@ static int DetectIPProtoSetup(DetectEngineCtx *de_ctx, Signature *s, const char
 
  error:
 
+    DetectIPProtoFree(data);
     return -1;
 }