media: i2c: ov9282: add strobe output enable v4l2 control

Add V4L2_CID_FLASH_STROBE_OE enable/disable support using the
"strobe output enable" feature of the sensor.

All values are based on the OV9281 datasheet v1.53 (january 2019) and
tested using an ov9281 VisionComponents module.

Signed-off-by: Richard Leitner <richard.leitner@linux.dev>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index d7448728cdd1007bd25ba301e9b5ade3a853e0e8..cd4d234d7056ea33edcb20616dac9732802cfcaa 100644 (file)
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -670,6 +670,23 @@ static int ov9282_set_ctrl_vflip(struct ov9282 *ov9282, int value)
                                current_val);
 }
 
+static int ov9282_set_ctrl_flash_strobe_oe(struct ov9282 *ov9282, bool enable)
+{
+       u32 current_val;
+       int ret;
+
+       ret = ov9282_read_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, &current_val);
+       if (ret)
+               return ret;
+
+       if (enable)
+               current_val |= OV9282_OUTPUT_ENABLE6_STROBE;
+       else
+               current_val &= ~OV9282_OUTPUT_ENABLE6_STROBE;
+
+       return ov9282_write_reg(ov9282, OV9282_REG_OUTPUT_ENABLE6, 1, current_val);
+}
+
 /**
  * ov9282_set_ctrl() - Set subdevice control
  * @ctrl: pointer to v4l2_ctrl structure
@@ -736,6 +753,9 @@ static int ov9282_set_ctrl(struct v4l2_ctrl *ctrl)
                ret = ov9282_write_reg(ov9282, OV9282_REG_TIMING_HTS, 2,
                                       (ctrl->val + ov9282->cur_mode->width) >> 1);
                break;
+       case V4L2_CID_FLASH_STROBE_OE:
+               ret = ov9282_set_ctrl_flash_strobe_oe(ov9282, ctrl->val);
+               break;
        default:
                dev_err(ov9282->dev, "Invalid control %d", ctrl->id);
                ret = -EINVAL;
@@ -1325,7 +1345,7 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
        u32 lpfr;
        int ret;
 
-       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 10);
+       ret = v4l2_ctrl_handler_init(ctrl_hdlr, 11);
        if (ret)
                return ret;
 
@@ -1390,6 +1410,10 @@ static int ov9282_init_controls(struct ov9282 *ov9282)
                                                OV9282_TIMING_HTS_MAX - mode->width,
                                                1, hblank_min);
 
+       /* Flash/Strobe controls */
+       v4l2_ctrl_new_std(ctrl_hdlr, &ov9282_ctrl_ops,
+                         V4L2_CID_FLASH_STROBE_OE, 0, 1, 1, 0);
+
        ret = v4l2_fwnode_device_parse(ov9282->dev, &props);
        if (!ret) {
                /* Failure sets ctrl_hdlr->error, which we check afterwards anyway */