]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
KVM: nSVM: Drop redundant/wrong comment in nested_vmcb02_prepare_save()
authorYosry Ahmed <yosry.ahmed@linux.dev>
Tue, 13 Jan 2026 17:28:07 +0000 (17:28 +0000)
committerSean Christopherson <seanjc@google.com>
Wed, 14 Jan 2026 17:07:03 +0000 (09:07 -0800)
The comment above DR6 and DR7 initializations is redundant, because the
entire function follows the same pattern of only initializing the fields
in vmcb02 if the vmcb12 changed or the fields are dirty, which handles
the first execution case.

Also, the comment refers to new_vmcb12 as new_vmcs12. Just drop the
comment.

No functional change intended.

Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
Link: https://patch.msgid.link/20260113172807.2178526-1-yosry.ahmed@linux.dev
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/svm/nested.c

index 5aa0512e09c9319e4b0fdda5809d0d74069b3df4..79cb85b8a15688cfbf888b0e10c83a6e9d470912 100644 (file)
@@ -681,7 +681,6 @@ static void nested_vmcb02_prepare_save(struct vcpu_svm *svm, struct vmcb *vmcb12
        vmcb02->save.rsp = vmcb12->save.rsp;
        vmcb02->save.rip = vmcb12->save.rip;
 
-       /* These bits will be set properly on the first execution when new_vmc12 is true */
        if (unlikely(new_vmcb12 || vmcb_is_dirty(vmcb12, VMCB_DR))) {
                vmcb02->save.dr7 = svm->nested.save.dr7 | DR7_FIXED_1;
                svm->vcpu.arch.dr6  = svm->nested.save.dr6 | DR6_ACTIVE_LOW;